[PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

[Michael Zoran]

On Sun, 2017-03-19 at 11:39 +0100, Stefan Wahren wrote:
> Hi Michael,
> 
> > Michael Zoran <mzoran at crowfest.net> hat am 19. März 2017 um 05:42
> > geschrieben:
> > 
> > 
> > On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote:
> > > > Michael Zoran <mzoran at crowfest.net> hat am 17. März 2017 um
> > > > 16:22
> > > > geschrieben:
> > > > 
> > > > 
> > > > From: Dave Stevenson <dave.stevenson at raspberrypi.org>
> > > > 
> > > > Pi3 and Compute Module 3 have a GPIO expander that the
> > > > VPU communicates with.
> > > > There is a mailbox service that now allows control of this
> > > > expander, so add a kernel driver that can make use of it.
> > > > 
> > > > Pwr_led node added to device-tree for Pi3.
> > > 
> > > Looks like debris
> > > 
> > > > 
> > > > Signed-off-by: Dave Stevenson <dave.stevenson at raspberrypi.org>
> > > > 
> > > > Stripped off changes to Makefile and Kconfig
> > > > Also stripped off changes to raspberrypi-firmware.h
> > > > Moved to drivers/staging/vc04_services/bcm2835-firmware-gpio
> > > > 
> > > > Signed-off-by: Michael Zoran <mzoran at crowfest.net>
> > > > ---
> > > > 
> > 
> > Hi Stefan,
> > 
> > For this particular patch, I simply cherry-picked the orignal
> > version
> > of the driver in the github directory.  It's a 100% original copy
> > of
> > the initial version.
> > 
> > So any grips/complaints should be sent to dave.stevenson at raspberryp
> > i.or
> > g.
> 
> do you want to fool me? I ask you before if you are interested in
> comments about this series, but you aren't about the actual driver?
> 
> > 
> > Or better yet, if the driver is accepted then you can contribute to
> > making it better.
> > 
> 
> Sorry, this is a slap in the face of someone reviewing patches in his
> spare-time.
> 
> Stefan

Sorry, I simply meant that I was hoping the comments would focus on
changes I made to the driver not the original version. I don't want
things to get mixed up between what I wrote and what Dave Stevenson
wrote.

Since the API is completely documented, I see no reason we or anybody
couldn't essentially rewrite the driver while it's in staging.  I just
think it would be best for everyone if the new version was a drop in
replacement for the original version.  Essential an enhancement rather
then a competitor.

I'm sorry this was a slap in the face.  I didn't intend it to be.  And
yes I enjoy your comments on how things could be improved and I really
accept that everyone is short on time.

Sorry.