[PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

Stefan Wahren stefan.wahren at i2se.com
Sun Mar 19 03:39:43 PDT 2017


Hi Michael,

> Michael Zoran <mzoran at crowfest.net> hat am 19. März 2017 um 05:42 geschrieben:
> 
> 
> On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote:
> > > Michael Zoran <mzoran at crowfest.net> hat am 17. März 2017 um 16:22
> > > geschrieben:
> > > 
> > > 
> > > From: Dave Stevenson <dave.stevenson at raspberrypi.org>
> > > 
> > > Pi3 and Compute Module 3 have a GPIO expander that the
> > > VPU communicates with.
> > > There is a mailbox service that now allows control of this
> > > expander, so add a kernel driver that can make use of it.
> > > 
> > > Pwr_led node added to device-tree for Pi3.
> > 
> > Looks like debris
> > 
> > > 
> > > Signed-off-by: Dave Stevenson <dave.stevenson at raspberrypi.org>
> > > 
> > > Stripped off changes to Makefile and Kconfig
> > > Also stripped off changes to raspberrypi-firmware.h
> > > Moved to drivers/staging/vc04_services/bcm2835-firmware-gpio
> > > 
> > > Signed-off-by: Michael Zoran <mzoran at crowfest.net>
> > > ---
> > > 
> 
> Hi Stefan,
> 
> For this particular patch, I simply cherry-picked the orignal version
> of the driver in the github directory.  It's a 100% original copy of
> the initial version.
> 
> So any grips/complaints should be sent to dave.stevenson at raspberrypi.or
> g.

do you want to fool me? I ask you before if you are interested in comments about this series, but you aren't about the actual driver?

> 
> Or better yet, if the driver is accepted then you can contribute to
> making it better.
> 

Sorry, this is a slap in the face of someone reviewing patches in his spare-time.

Stefan



More information about the linux-rpi-kernel mailing list