[PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

Stefan Wahren stefan.wahren at i2se.com
Sun Mar 19 07:47:10 PDT 2017

> Michael Zoran <mzoran at crowfest.net> hat am 19. März 2017 um 12:38 geschrieben:
> ...
> Sorry, I simply meant that I was hoping the comments would focus on
> changes I made to the driver not the original version. I don't want
> things to get mixed up between what I wrote and what Dave Stevenson
> wrote.

This isn't possible here, because the kernel must be bisectable. We can't introduce build issues and fix them later. I didn't want to say my comments should be fixed in the initial commit. It's possible to fix the minor ones as separate patches and add the bigger ones into the TODO file.

> Since the API is completely documented, I see no reason we or anybody
> couldn't essentially rewrite the driver while it's in staging.  I just
> think it would be best for everyone if the new version was a drop in
> replacement for the original version.  Essential an enhancement rather
> then a competitor.

I think my comments weren't fundamental changes, but you surely mean the devicetree ABI? I like to see this driver ASAP out of staging and i'm not interested to maintain 2 functional identical driver only to keep compability with the Foundation tree. Currently i'm afraid that we build up many drivers in staging, which need a complete rewrite later if they should come out of staging. It would be nice if we could avoid the situation we have with the thermal driver.


More information about the linux-rpi-kernel mailing list