[PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode

Vaibhav Hiremath vaibhav.hiremath at linaro.org
Fri Jul 3 11:13:18 PDT 2015

On Friday 03 July 2015 08:57 PM, Robert Jarzmik wrote:
> Vaibhav Hiremath <vaibhav.hiremath at linaro.org> writes:
>> In case of timeout during msg xfer assert reset to
>> i2c controller for both interrupt and PIO mode of operation.
>> Signed-off-by: Jett.Zhou <jtzhou at marvell.com>
>> [vaibhav.hiremath at linaro.org: Split & merge patches into logical changes
>> and update the Changelog]
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath at linaro.org>
> I already said it previously, I'm against an unconditional reset in a timeout
> path. Make it a quirk or whatever, but in the current status, I'm against.
> The previous behavior looks correct to me : upon timeout, retry, no need to
> reset.

We still do return RETRY here, but also assert reset to I2C.

Anyway, lets revisit this again later. I will remove it in my next


More information about the linux-arm-kernel mailing list