[PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode

Robert Jarzmik robert.jarzmik at free.fr
Fri Jul 3 08:27:25 PDT 2015


Vaibhav Hiremath <vaibhav.hiremath at linaro.org> writes:

> In case of timeout during msg xfer assert reset to
> i2c controller for both interrupt and PIO mode of operation.
>
> Signed-off-by: Jett.Zhou <jtzhou at marvell.com>
> [vaibhav.hiremath at linaro.org: Split & merge patches into logical changes
> and update the Changelog]
> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath at linaro.org>

I already said it previously, I'm against an unconditional reset in a timeout
path. Make it a quirk or whatever, but in the current status, I'm against.

The previous behavior looks correct to me : upon timeout, retry, no need to
reset.

--
Robert



More information about the linux-arm-kernel mailing list