[PATCH-V2 07/12] i2c:pxa: Use devm_ variants in probe function
Robert Jarzmik
robert.jarzmik at free.fr
Fri Jul 3 08:28:02 PDT 2015
Vaibhav Hiremath <vaibhav.hiremath at linaro.org> writes:
> @@ -1201,16 +1201,17 @@ static int i2c_pxa_probe(struct platform_device *dev)
>
> strlcpy(i2c->adap.name, "pxa_i2c-i2c", sizeof(i2c->adap.name));
>
> - i2c->clk = clk_get(&dev->dev, NULL);
> + i2c->clk = devm_clk_get(&dev->dev, NULL);
> if (IS_ERR(i2c->clk)) {
> - ret = PTR_ERR(i2c->clk);
> - goto eclk;
> + dev_err(&dev->dev, "failed to get the clk\n");
For consistency's sake, please use :
dev_err(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk));
Once that is done, you can add my :
Acked-by: Robert Jarzmik <robert.jarzmik at free.fr>
--
Robert
More information about the linux-arm-kernel
mailing list