[PATCH v2] arm: omap: Fix errors and warnings when building for one board
Premi, Sanjeev
premi at ti.com
Fri Oct 28 10:10:50 EDT 2011
> -----Original Message-----
> From: Premi, Sanjeev
> Sent: Thursday, October 13, 2011 9:44 PM
> To: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Cc: Premi, Sanjeev
> Subject: [PATCH v2] arm: omap: Fix errors and warnings when
> building for one board
>
> When customizing omap2plus_defconfig to build for only
> one board (omap3evm), I came across these warnings and
> errors (filenames truncated):
>
> arch/arm/mach-omap2/board-generic.c:76:20: warning:
> 'omap4_init' defined but not used
> arch/arm/mach-omap2/built-in.o: In function `omap2420_init_early':
> arch/arm/mach-omap2/io.c:364: undefined reference to
> `omap2_set_globals_242x'
> arch/arm/mach-omap2/io.c:366: undefined reference to
> `omap2xxx_voltagedomains_init'
> arch/arm/mach-omap2/io.c:367: undefined reference to
> `omap242x_powerdomains_init'
> arch/arm/mach-omap2/io.c:368: undefined reference to
> `omap242x_clockdomains_init'
> arch/arm/mach-omap2/io.c:369: undefined reference to
> `omap2420_hwmod_init'
> arch/arm/mach-omap2/built-in.o: In function `omap2430_init_early':
> arch/arm/mach-omap2/io.c:376: undefined reference to
> `omap2_set_globals_243x'
> arch/arm/mach-omap2/io.c:378: undefined reference to
> `omap2xxx_voltagedomains_init'
> arch/arm/mach-omap2/io.c:379: undefined reference to
> `omap243x_powerdomains_init'
> arch/arm/mach-omap2/io.c:380: undefined reference to
> `omap243x_clockdomains_init'
> arch/arm/mach-omap2/io.c:381: undefined reference to
> `omap2430_hwmod_init'
> arch/arm/mach-omap2/built-in.o: In function `omap4430_init_early':
> arch/arm/mach-omap2/io.c:436: undefined reference to
> `omap2_set_globals_443x'
> arch/arm/mach-omap2/io.c:438: undefined reference to
> `omap44xx_voltagedomains_init'
> arch/arm/mach-omap2/io.c:439: undefined reference to
> `omap44xx_powerdomains_init'
> arch/arm/mach-omap2/io.c:440: undefined reference to
> `omap44xx_clockdomains_init'
> arch/arm/mach-omap2/io.c:441: undefined reference to
> `omap44xx_hwmod_init'
>
> This patch fixes them.
>
> Signed-off-by: Sanjeev Premi <premi at ti.com>
> ---
>
> Changes since v1:
> - #if defined() to #ifdef
> - Moved an #ifdef to take care of additional warning
> related to sdp4430_twldata. Had missed squashing the
> patch before sending v1.
>
> Adding ifdefs makes the code bit ugly and is prone to propagate
> further. Not sure if DT will help here, but this patch would be
> useful for people trying to build for individual boards.
>
> Compile tested for OMAP3EVM.
>
> Applies to linux-omap/master at:
> fb4df0f : ARM: OMAP1: Fix warnings about enabling 32 KiHz timer
>
>
> arch/arm/mach-omap2/board-generic.c | 8 ++++++++
> arch/arm/mach-omap2/io.c | 6 ++++++
> 2 files changed, 14 insertions(+), 0 deletions(-)
>
Tony,
Just wanted to check the status of this patch.
~sanjeev
More information about the linux-arm-kernel
mailing list