[PATCH] gpio/samsung: Complain loudly if we don't know the SoC
Mark Brown
broonie at opensource.wolfsonmicro.com
Mon Oct 17 17:33:03 EDT 2011
On Mon, Oct 17, 2011 at 03:07:47PM -0600, Grant Likely wrote:
> On Mon, Oct 17, 2011 at 3:04 PM, Mark Brown
> > If we don't know the SoC type then we won't add any chips which is rather
> > unfortunate as neither GPIO nor pinmux APIs will work, breaking lots of
> > different subsystems. Logging at least provides a hint to the user as to
> > what's gone wrong.
> > Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
> Be Bolder! May as well use WARN() and be really obnoxious. :-)
Actually what's really unfortunate here is that in most configurations
this will cause a catastrophic failure to boot so we never get far
enough to see the logging at all. We really need aSCREAM_THROUGH_DEBUG_LL()
or whatever. Or to fix these things to dump via that route if we don't
have the console up yet, which is going to be more practical.
More information about the linux-arm-kernel
mailing list