[PATCH] arm: omap: Fix errors and warnings when building for one board

[Russell King - ARM Linux]

On Thu, Oct 13, 2011 at 08:36:19PM +0530, Premi, Sanjeev wrote:
> > -----Original Message-----
> > From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk] 
> > Sent: Thursday, October 13, 2011 8:26 PM
> > To: Premi, Sanjeev
> > Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> > Subject: Re: [PATCH] arm: omap: Fix errors and warnings when 
> > building for one board
> > 
> > On Thu, Oct 13, 2011 at 08:23:43PM +0530, Sanjeev Premi wrote:
> > > +#if defined(CONFIG_ARCH_OMAP4)
> > 
> > Please use #ifdef unless you're intending to expand the condition.
> > 
> 
> I tried to be consistent with existing use of #if defined() in the
> file(s). Will change it.

Thanks.

> Should I change the other instances as well?

I'd suggest not - though I can't really tell as I don't have a version
with that to look at.