[PATCH] arm: omap: Fix errors and warnings when building for one board

Premi, Sanjeev premi at ti.com
Thu Oct 13 11:06:19 EDT 2011


> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk] 
> Sent: Thursday, October 13, 2011 8:26 PM
> To: Premi, Sanjeev
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH] arm: omap: Fix errors and warnings when 
> building for one board
> 
> On Thu, Oct 13, 2011 at 08:23:43PM +0530, Sanjeev Premi wrote:
> > +#if defined(CONFIG_ARCH_OMAP4)
> 
> Please use #ifdef unless you're intending to expand the condition.
> 

I tried to be consistent with existing use of #if defined() in the
file(s). Will change it.

Should I change the other instances as well?

~sanjeev



More information about the linux-arm-kernel mailing list