[PATCH 2/8] macb: detect hclk presence from platform data
Jamie Iles
jamie at jamieiles.com
Fri Mar 11 08:08:26 EST 2011
On Fri, Mar 11, 2011 at 01:47:57PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:54 Fri 11 Mar , Jamie Iles wrote:
> > On Fri, Mar 11, 2011 at 02:44:00AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 10:10 Thu 10 Mar , Jamie Iles wrote:
> > > > +#ifdef CONFIG_ARCH_AT91
> > > > +#define PCLK_NAME "macb_clk"
> > > > +#else /* CONFIG_ARCH_AT91 */
> > > > +#define PCLK_NAME "pclk"
> > > > +#endif
> > >
> > > we need change the clock name and avoid the ifdef
> > > so this will be generic
> > >
> > > nb I work on the switch to clkdev currently for avr32 and at91
> >
> > This should be gone now. Russell made the suggestion to have a fake clk
> > for hclk on AT91 so I think I've solved that now. There's an updated
> > patch in my reply to Russell's message but essentially I'm using
> > at91_clock_associate() to turn "macb_pclk" into "hclk" and "pclk". Does
> > this seem reasonable?
> please do not use at91_clock_associate as I'm going to remove it as use static
> clock as done on shmobile as example
> so if it's a fake clock please as ochi_clk on 9g45
Ok, that's fine. How about for the "macb_plk" though, won't that need
an at91_clock_associate() or is it OK to rename all of the macb_clk
definitions to have be called "pclk"?
Jamie
More information about the linux-arm-kernel
mailing list