[PATCH 1/2] [ARM] [IMX]: Removed superfluous checks for argument validity.

[Vladimir Zapolskiy]

Hello Uwe,

__clk_enable() and __clk_disable() are recursive with another arguments,
that means it is hardly possible to remove the checks from them.

2010/3/17 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

> Hello Vladimir,
>
> On Wed, Mar 17, 2010 at 10:11:55AM +0300, Vladimir Zapolskiy wrote:
> > The checks for clk argument are doubled in __clk_disable() and
> > __clk_enable() functions and thus may be skipped in clk_disable() and
> > clk_enable() bodies.
> Maybe better get rid of the test in __clk_{en,dis}able, as these are
> called more often?  Actually I think even a WARN_ON(clk == NULL ||
> IS_ERR(clk)) would be OK.
>
> Best regards
> Uwe
>
> With best wishes,
Vladimir
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100317/08a7f91b/attachment-0001.htm>