[PATCH 1/2] [ARM] [IMX]: Removed superfluous checks for argument validity.

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Mar 17 05:13:49 EDT 2010

Hello Vladimir,

On Wed, Mar 17, 2010 at 10:11:55AM +0300, Vladimir Zapolskiy wrote:
> The checks for clk argument are doubled in __clk_disable() and
> __clk_enable() functions and thus may be skipped in clk_disable() and
> clk_enable() bodies.
Maybe better get rid of the test in __clk_{en,dis}able, as these are
called more often?  Actually I think even a WARN_ON(clk == NULL ||
IS_ERR(clk)) would be OK.

Best regards

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

More information about the linux-arm-kernel mailing list