[PATCH 5/7] Add default_radius_vlan in sta_info

Jouni Malinen j at w1.fi
Wed Nov 3 14:28:23 PDT 2021

On Mon, Oct 11, 2021 at 01:24:35PM +0200, Tom Barthe wrote:
> Used to store the vlan_description corresponding to RADIUS tag 0.

> diff --git a/src/ap/sta_info.h b/src/ap/sta_info.h
> @@ -200,8 +200,9 @@ struct sta_info {
>  	struct hostapd_sta_wpa_psk_short *psk;
> +	struct vlan_description default_radius_vlan;

This would increase the size of struct sta_info by 34*sizeof(int)
unconditionally for all cases regardless of whether this
RADIUS-controlled PSK/passphrase-to-VLAN-mapping is used. That feels a
bit excessive.. Does this really need that full data structure to be
stored? Maybe a better way of doing this would be to introduce a new
data structure that would hold both of those two members here and that
data structure would be allocated conditionally only when the
RADIUS-based design is used.
Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list