[PATCH 7/7] Remove useless variable

Jouni Malinen j at w1.fi
Wed Nov 3 14:24:45 PDT 2021


On Mon, Oct 11, 2021 at 01:24:37PM +0200, Tom Barthe wrote:
> diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
> @@ -2321,12 +2321,11 @@ ieee802_11_set_radius_info(struct hostapd_data *hapd, struct sta_info *sta,
>  {
>  	u32 session_timeout = info->session_timeout;
>  	u32 acct_interim_interval = info->acct_interim_interval;
> -	struct vlan_description *vlan_id = &info->vlan_id;
>  	struct hostapd_sta_wpa_psk_short *psk = info->psk;
>  	char *identity = info->identity;
>  	char *radius_cui = info->radius_cui;
>  
> -	sta->default_radius_vlan = *vlan_id;
> +	sta->default_radius_vlan = info->vlan_id;

This looks a bit strange as a separate patch since that
sta->default_radius_vlan does not even exist before the earlier patches
in this series. Maybe this should be merged into the patch 5/7 instead.
 
-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list