[PATCH 1/5] commands: nv: fail with verbose message if invoked without args
Stefan Lengfeld
contact at stefanchrist.eu
Tue Oct 31 10:51:25 PDT 2017
Hi Jorns,
On Mon, Oct 30, 2017 at 11:34:17AM +0100, Enrico Jorns wrote:
> Signed-off-by: Enrico Jorns <ejo at pengutronix.de>
> ---
> commands/nv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/commands/nv.c b/commands/nv.c
> index 37cdb96647..1c5514dd32 100644
> --- a/commands/nv.c
> +++ b/commands/nv.c
> @@ -56,6 +56,7 @@ static int do_nv(int argc, char *argv[])
> argv += optind;
>
> if (argc < 1)
> + printf("Invalid usage: Missing argument");
> return COMMAND_ERROR_USAGE;
Missing curly brackets for if clause. Indentation does not matter in C
as it does in for example python. Now the function returns always
'COMMAND_ERROR_USAGE'.
Kind regards
Stefan
More information about the barebox
mailing list