[PATCH 2/3] net: fec: implement dtb property phy-reset-duration

[Stefan Christ]

Hi,
  
> shouldn't this be msec = 1000.
> 
> Here you set it to 1ms if it used to be over 1s.

Yeah, that would be the obvious and plausible thing to do, but the driver in
the linux kernel does it this way and it's documented in the device tree
bindings.  So I'm not sure if we can change the default behavior here.

Mit freundlichen Grüßen / Kind regards,
	Stefan Christ

On Mon, Nov 16, 2015 at 11:03:32AM +0100, Holger Schurig wrote:
> 2015-11-16 10:00 GMT+01:00 Stefan Christ <s.christ at phytec.de>:
> 
> > +               /* A sane reset duration should not be longer than 1s */
> > +               if (msec > 1000)
> > +                       msec = 1;
> >
> 
> Hi Stefan,
> 
> shouldn't this be msec = 1000.
> 
> Here you set it to 1ms if it used to be over 1s.