[PATCH 2/3] net: fec: implement dtb property phy-reset-duration

Stefan Christ s.christ at phytec.de
Mon Nov 16 01:00:44 PST 2015


Implement device tree property phy-reset-duration to adjust length of
phy reset. Resetting the reset time to 1ms when it's greater than 1000ms
is the documented behavior in dts/Bindings/net/fsl-fec.txt and in the
linux kernel.

Signed-off-by: Stefan Christ <s.christ at phytec.de>
---
 drivers/net/fec_imx.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
index f19d046..39a5cea 100644
--- a/drivers/net/fec_imx.c
+++ b/drivers/net/fec_imx.c
@@ -654,6 +654,7 @@ static int fec_probe(struct device_d *dev)
 	int ret;
 	enum fec_type type;
 	int phy_reset;
+	u32 msec = 1;
 
 	ret = dev_get_drvdata(dev, (const void **)&type);
 	if (ret)
@@ -684,6 +685,11 @@ static int fec_probe(struct device_d *dev)
 
 	phy_reset = of_get_named_gpio(dev->device_node, "phy-reset-gpios", 0);
 	if (gpio_is_valid(phy_reset)) {
+		of_property_read_u32(dev->device_node, "phy-reset-duration", &msec);
+		/* A sane reset duration should not be longer than 1s */
+		if (msec > 1000)
+			msec = 1;
+
 		ret = gpio_request(phy_reset, "phy-reset");
 		if (ret)
 			goto err_free;
@@ -692,7 +698,7 @@ static int fec_probe(struct device_d *dev)
 		if (ret)
 			goto err_free;
 
-		mdelay(1);
+		mdelay(msec);
 		gpio_set_value(phy_reset, 1);
 	}
 
-- 
1.9.1




More information about the barebox mailing list