[PATCH] drivers/pwm: add PXA pulse width modulator controller
robert.jarzmik at free.fr
Thu Feb 9 06:50:17 EST 2012
Sascha Hauer <s.hauer at pengutronix.de> writes:
> Experience shows that the framebuffer shouldn't be enabled on
> initialization time. If it does you end up with a framebuffer showing
> a blank screen in the best case. Instead the framebuffer should be
> enabled explicitely once there is an image on the screen which looks
> much nicer to the user. That said the following should be removed from
> the pxafb driver:
> if (pdata->enable_on_load)
> Are you ok with that?
For the pxafb, yes agreed.
I still see a small issue with the PWM API.
When I register the pxa-pwm driver, I have :
pxa_pwm_probe(struct device_d *dev)
-> base = dev_request_mem_region(dev, 0);
-> pxa_pwm = xzalloc(...)
-> pxa_pwm->name = drv_name(...)
-> pxa_pwm->ops = &pxa_pwm_ops,
As you can see, the "base" is lost, and I have no way to store it in the
Shouldn't the pwm_chip structure have a priv pointer ?
More information about the barebox