[PATCH 5/7] ARM i.MX51: Add support for the Efika MX Smartbook

[Peter Korsgaard]

>>>>> "Sascha" == Sascha Hauer <s.hauer at pengutronix.de> writes:

Hi,

 Sascha> +
 Sascha> +	/* USB HOST2 */
 Sascha> +	MX51_PAD_EIM_D27__GPIO2_9,
 Sascha> +	MX51_PAD_GPIO1_5__GPIO1_5,
 Sascha> +	MX51_PAD_EIM_D16__USBH2_DATA0,
 Sascha> +	MX51_PAD_EIM_D17__USBH2_DATA1,
 Sascha> +	MX51_PAD_EIM_D18__USBH2_DATA2,
 Sascha> +	MX51_PAD_EIM_D19__USBH2_DATA3,
 Sascha> +	MX51_PAD_EIM_D20__USBH2_DATA4,
 Sascha> +	MX51_PAD_EIM_D21__USBH2_DATA5,
 Sascha> +	MX51_PAD_EIM_D22__USBH2_DATA6,
 Sascha> +	MX51_PAD_EIM_D23__USBH2_DATA7,
 Sascha> +	MX51_PAD_EIM_A24__USBH2_CLK,
 Sascha> +	MX51_PAD_EIM_A25__USBH2_DIR,
 Sascha> +	MX51_PAD_EIM_A26__GPIO2_20,
 Sascha> +	MX51_PAD_EIM_A27__USBH2_NXT,
 Sascha> +
 Sascha> +	/* USB HOST1 */
 Sascha> +        MX51_PAD_USBH1_CLK__USBH1_CLK,
 Sascha> +        MX51_PAD_USBH1_DIR__USBH1_DIR,
 Sascha> +        MX51_PAD_USBH1_NXT__USBH1_NXT,
 Sascha> +        MX51_PAD_USBH1_DATA0__USBH1_DATA0,
 Sascha> +        MX51_PAD_USBH1_DATA1__USBH1_DATA1,
 Sascha> +        MX51_PAD_USBH1_DATA2__USBH1_DATA2,
 Sascha> +        MX51_PAD_USBH1_DATA3__USBH1_DATA3,
 Sascha> +        MX51_PAD_USBH1_DATA4__USBH1_DATA4,
 Sascha> +        MX51_PAD_USBH1_DATA5__USBH1_DATA5,
 Sascha> +        MX51_PAD_USBH1_DATA6__USBH1_DATA6,
 Sascha> +        MX51_PAD_USBH1_DATA7__USBH1_DATA7,
 Sascha> +	MX51_PAD_USBH1_STP__GPIO1_27,
 Sascha> +	MX51_PAD_EIM_A16__GPIO2_10,

Tab/spaces mixup.

Any specific reason to list USB2 before USB1?


 Sascha> +	/* USB U-Boot */
 Sascha> +	MX51_PAD_EIM_A22__GPIO2_16, /* WLAN enable (1 = on) */
 Sascha> +	MX51_PAD_EIM_A17__GPIO2_11,

That USB U-Boot comment is a bit odd.

 Sascha> +/*
 Sascha> + * Generally this should work on the Efika MX smarttop aswell,
 Sascha> + * but I do not have the hardware to test it, so hardcode this
 Sascha> + * for the smartbook for now.
 Sascha> + */

I have both a smarttop and smartbook, so I'll try to find some time to
test.

 Sascha> +
 Sascha> +	/* Raise the core frequency to 800MHz */
 Sascha> +	console_flush();	

Trailing spaces.


 Sascha> +++ b/arch/arm/boards/efika-mx-smartbook/config.h
 Sascha> @@ -0,0 +1,24 @@
 Sascha> +/**
 Sascha> + * @file
 Sascha> + * @brief Global defintions for the ARM i.MX51 based babbage board

Should probably say efikamx smartbook instead. s/defintions/definitions/

-- 
Bye, Peter Korsgaard