[PATCH 01/13] ath10k: introduce dynamic WMI structures

Kalle Valo kvalo at qca.qualcomm.com
Thu Sep 26 04:54:52 EDT 2013


Bartosz Markowski <bartosz.markowski at tieto.com> writes:

> This is the initial framework to implement dynamic
> WMI API in order to support new firmware (from so
> called 10.X branch)
>
> The realization is to have a static WMI cmd map for
> each of the firmwares, registered upom wmi init.
>
> This patch creates such map for MAIN FW, updates
> wmi_cmd_send() calls to take as a parameter
> the map value instead of direct WMI enum.
>
> As soon as complete 10.X API will be on place,
> we will introduce the FW IE mechanics to dynamicaly
> identify which FW is being used and based on that
> we will use correct map, API, structures, etc.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski at tieto.com>
> ---

[...]

> @@ -1293,7 +1438,8 @@ int ath10k_wmi_pdev_resume_target(struct ath10k *ar)
>  	if (skb == NULL)
>  		return -ENOMEM;
>  
> -	return ath10k_wmi_cmd_send(ar, skb, WMI_PDEV_RESUME_CMDID);
> +	return ath10k_wmi_cmd_send(ar, skb,
> +				   ar->wmi.cmd->wmi_pdev_resume_cmdid);
>  }

I was thinking of adding a macro WMI_PDEV_RESUME_CMDID(ar) for all
dynamic wmi ids, that way it would look as closely as possible with the
original code. But I'm not sure if that makes sense anymore. Thoughts?

-- 
Kalle Valo



More information about the ath10k mailing list