[PATCH 4/9] libnvme: add support for retrieving per-path gendisk I/O statistics
Nilay Shroff
nilay at linux.ibm.com
Fri Apr 3 08:36:19 PDT 2026
On 4/1/26 9:12 PM, Daniel Wagner wrote:
> Hi Nilay,
>
> Sorry for the late response.
No worries:-)
>
> On Tue, Mar 24, 2026 at 06:32:59PM +0530, Nilay Shroff wrote:
>> After updating the stat, the caller/nvme-cli invokes nvme_path_get_xxx()
>> APIs to retrieve specific metrics. These APIs also take the current index
>> and compute results by comparing the current and previous statistics.
>
> Let's try to avoid leaking internal implementation details to the public
> API. This makes it unnecessary hard to maintain.
>
> The stats update function could take an argument what it should do:
> - update internal stats, calculate diff -> getters return the diff
> - update internal stats, getters return the absolute value
>
Yes got it.. I think we could do this way. I will give it a shot
and respin a new patchset with the above change.
Thanks,
--Nilay
More information about the Linux-nvme
mailing list