[PATCH 6/9] libnvme: add support for per-path diagnostic counters

[Daniel Wagner]

On Tue, Mar 24, 2026 at 07:24:11PM +0530, Nilay Shroff wrote:
> There are essentially two options,
> 
> 1. Include the diagnostic counter patches now:
>    In this case, nvme-cli/nvme-top can start using the libnvme APIs immediately.
>    If the kernel does not yet expose these attributes, the counters will appear
>    as zero in the dashboard. Once the kernel support lands, the correct values
>    will automatically be reflected without requiring further changes to libnvme
>    or nvme-cli (unless the sysfs layout changes).
> 
> 2. Defer the diagnostic counter patches:
>    In this case, the counters would be omitted from the nvme-top dashboard for now.
>    Once kernel support is available, we would need to update nvme-top (and libnvme)
>    to add them.
> 
> Given these options, I would lean towards option (1), but I’m happy to go with
> your preference.

I’m not sure if I read the room right, but I sensed the patches might be
blocked by the libmultipath project. If they’re just delayed for the
usual reasons, I’m fine with option (1).

FWIW, the 3.0 release is still months away, so there’s no hurry. I still
have a few TODO items and want to wait for feedback from LSFMM. I’ll
likely start the -rc cycle after that. Realistically, 3.0 won't land
until August.