[PATCH 4/9] libnvme: add support for retrieving per-path gendisk I/O statistics

Daniel Wagner dwagner at suse.de
Wed Apr 1 08:42:55 PDT 2026


Hi Nilay,

Sorry for the late response.

On Tue, Mar 24, 2026 at 06:32:59PM +0530, Nilay Shroff wrote:
> After updating the stat, the caller/nvme-cli invokes nvme_path_get_xxx()
> APIs to retrieve specific metrics. These APIs also take the current index
> and compute results by comparing the current and previous statistics.

Let's try to avoid leaking internal implementation details to the public
API. This makes it unnecessary hard to maintain.

The stats update function could take an argument what it should do:
  - update internal stats, calculate diff -> getters return the diff
  - update internal stats, getters return the absolute value

Thanks,
Daniel



More information about the Linux-nvme mailing list