[Freeassociation-devel] libical fix recurrence not excluded when it should be

[dothebart]

>  Fr Sep 04 2009 07:41:46 EDT von  "Patrick Ohly" <patrick.ohly at gmx.de> 
>Betreff: Re: [Freeassociation-devel] libical fix recurrence not excluded when
>it should be
>
>  I really don't know. What surprises me about Gren's original report
> ("icalproperty_recurrence_is_excluded" does not take into account any
> timezone associated with EXDATEs being tested") is that in Evolution,
> EXDATEs with TZID are the rule, not the exception. That has worked,
> whereas I know from real-life problems that EXDATES with UTC were not
> handled.
> 
> Anyway, the test shows that the current code works. It didn't cover the
> EXDATE in UTC case; I have added that and it still passes (patch
> attached). So this looks good to go into a release.
> 
> Note that I ran into other issues trying to run "make check". Patches
> also attached.
> 
> -- 
> Bye, Patrick Ohly
> -- 
> Patrick.Ohly at gmx.de
> http://www.estamos.de/
> 
> 
>
>
>  

  

Thanks a lot! I guess your patches plus removing the now unnedef function
will make the next release.  

Any other opinions on that? Art? Allen?  

   

   

Wilfried Goesgens
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2657452d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-test_recurrenceexcluded-check-EXDATE-in-UTC-handl.patch
Type: text/x-patch
Size: 1938 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2657452d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001--make-check-failure-libical-icalss.h-not-found.patch
Type: text/x-patch
Size: 1717 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2657452d/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002--make-check-build-failure-out-of-tree-compilation.patch
Type: text/x-patch
Size: 951 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2657452d/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003--make-check-on-64-bit-segfault-due-to-valist-termi.patch
Type: text/x-patch
Size: 16105 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2657452d/attachment-0003.bin>