[Freeassociation-devel] libical fix recurrence not excluded when it should be

[Patrick Ohly]

On Fri, 2009-08-07 at 11:29 -0400, dothebart wrote:
> having a look at the code you remove (since its just used in that
> place)
> 
> this function:
> 
> struct icaltimetype icalproperty_get_exdate(const icalproperty* prop){
[...]
> seems to live in an autogenerated file; its not in SVN? I also wasn't
> able to find that comment or the functionname anywhere else...
> 
> If that code causes the bug (since Gren basicaly did the fallback to
> the no more used #else case..) was that code a workaround for that big
> timezone bug?
> 
> If yes, should we remove the function and call it directly like Grens
> Patch suggests? or should we call this function and remove the #if?
> 
> Allen, Patrick, Art, some comment on this?

I really don't know. What surprises me about Gren's original report
("icalproperty_recurrence_is_excluded" does not take into account any
timezone associated with EXDATEs being tested") is that in Evolution,
EXDATEs with TZID are the rule, not the exception. That has worked,
whereas I know from real-life problems that EXDATES with UTC were not
handled.

Anyway, the test shows that the current code works. It didn't cover the
EXDATE in UTC case; I have added that and it still passes (patch
attached). So this looks good to go into a release.

Note that I ran into other issues trying to run "make check". Patches
also attached.

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001--make-check-failure-libical-icalss.h-not-found.patch
Type: text/x-patch
Size: 1670 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2c21d132/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002--make-check-build-failure-out-of-tree-compilation.patch
Type: text/x-patch
Size: 925 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2c21d132/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003--make-check-on-64-bit-segfault-due-to-valist-termi.patch
Type: text/x-patch
Size: 15604 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2c21d132/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-test_recurrenceexcluded-check-EXDATE-in-UTC-handl.patch
Type: text/x-patch
Size: 1899 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090904/2c21d132/attachment-0003.bin>