[Freeassociation-devel] libical fix recurrence not excluded when it should be

[Allen Winter]

On Friday 04 September 2009 8:55:37 am dothebart wrote:
> 
> >  Fr Sep 04 2009 07:41:46 EDT von  "Patrick Ohly" <patrick.ohly at gmx.de> 
> >Betreff: Re: [Freeassociation-devel] libical fix recurrence not excluded when
> >it should be
> >
> >  I really don't know. What surprises me about Gren's original report
> > ("icalproperty_recurrence_is_excluded" does not take into account any
> > timezone associated with EXDATEs being tested") is that in Evolution,
> > EXDATEs with TZID are the rule, not the exception. That has worked,
> > whereas I know from real-life problems that EXDATES with UTC were not
> > handled.
> > 
> > Anyway, the test shows that the current code works. It didn't cover the
> > EXDATE in UTC case; I have added that and it still passes (patch
> > attached). So this looks good to go into a release.
> > 
> > Note that I ran into other issues trying to run "make check". Patches
> > also attached.
> > 
> >
> >
> >  
> 
>   
> 
> Thanks a lot! I guess your patches plus removing the now unnedef function
> will make the next release.  
> 
> Any other opinions on that? Art? Allen?  
> 
My opinion: after committing Patrick's patches we should have a release.

-- 
Allen Winter | allen at kdab.net | Software Engineer
KDAB (USA), LLC, a KDAB Group company
Tel. USA +1-866-777-KDAB(5322), Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions