ath10k: fix peer limit enforcement

Dan Carpenter dan.carpenter at oracle.com
Wed Aug 19 05:41:08 PDT 2015


On Wed, Aug 19, 2015 at 01:19:32PM +0200, Michal Kazior wrote:
> On 18 August 2015 at 21:01, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> > Hello Michal Kazior,
> >
> > The patch e04cafbc38c7: "ath10k: fix peer limit enforcement" from Aug
> > 5, 2015, leads to the following static checker warning:
> >
> >         drivers/net/wireless/ath/ath10k/mac.c:4365 ath10k_add_interface()
> >         warn: inconsistent returns 'mutex:&ar->conf_mutex'.
> >           Locked on:   line 4125
> >           Unlocked on: line 4344
> >                        line 4365
> [...]
> 
> Great job finding this and the other one (dma_mapping_error) as well!
> I've just sent patches to fix them.

I re-wrote the dma_mapping_error() check yesteday but I will push it
soon.

> 
> I'd love to have this sort of static analysis in my tool set. What did
> you use (I have a weird feeling I did ask about it at one point..)?

This is a Smatch warning.

regards,
dan carpenter




More information about the ath10k mailing list