[PATCH 09/10] Use const with mac addresses

Olof Johansson dev at skyshaper.net
Tue May 28 03:29:51 EDT 2013


On Tue, May 28, 2013 at 9:08 AM, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> I think we shouldn't use either qualcomm or airgo OUI for the random
> address as they can conflict with addresses on real devices. IMHO using
> a local administered address space would be better. Isn't that what it
> is for?

Here is how the code works:
First it looks for 1 mac address file. If it can read that it uses
that as address[0]. The rest of the addresses are locally administered
based on this.
If there is no mac address file whatsoever, we need one, we use a QC
oui to randomize one address for address[0] and uses locally
administered for the rest.

So, basically, we should never use QC oui unless we're in a really bad
situation and has it as a fallback. Even the locally administered ones
need some form of base, and randomizing the first 3 bytes will only
put us in a situation thats equally bad.

Cheers
--
Olof



More information about the wcn36xx mailing list