[PATCH 09/10] Use const with mac addresses

[YanBo]

On Tue, May 28, 2013 at 3:08 PM, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> YanBo <dreamfly281 at gmail.com> writes:
>
>> Looks good,
>> one comments about qualcomm OUI value
>> -static const u8 qcom_oui[3] = {0x00, 0xA0, 0xC6};
>> The WCN36XX chips's oui is always marked as "{0x00, 0x0A, 0xF5}" which
>> stand for Airgo chipset, it is also match what it is original come
>> from
>
> I think we shouldn't use either qualcomm or airgo OUI for the random
> address as they can conflict with addresses on real devices. IMHO using
> a local administered address space would be better. Isn't that what it
> is for?

Yes, agree with your point, but add the benefit to use OUI is it is
easy to identify  the packet
info from some sniffer tools, like ominipeak etc, those tool always
change the OUI to string which
will be helpful to identify the packet.

BR /Yanbo