[PATCH 09/10] Use const with mac addresses

[Kalle Valo]

Olof Johansson <dev at skyshaper.net> writes:

> On Tue, May 28, 2013 at 9:08 AM, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> I think we shouldn't use either qualcomm or airgo OUI for the random
>> address as they can conflict with addresses on real devices. IMHO using
>> a local administered address space would be better. Isn't that what it
>> is for?
>
> Here is how the code works:
> First it looks for 1 mac address file. If it can read that it uses
> that as address[0]. The rest of the addresses are locally administered
> based on this.
> If there is no mac address file whatsoever, we need one, we use a QC
> oui to randomize one address for address[0] and uses locally
> administered for the rest.
>
> So, basically, we should never use QC oui unless we're in a really bad
> situation and has it as a fallback. Even the locally administered ones
> need some form of base, and randomizing the first 3 bytes will only
> put us in a situation thats equally bad.

Using a locally administered address would make it obvious that the
address isn't a properly allocated address and it wouldn't conflict with
real properly allocated addresses. But as long driver has a big fat
warning (like it now has) I'm happy :)

-- 
Kalle Valo