[PATCH] Check firmware version more precisely

[Eugene Krasnikov]

> I haven't tested your patch yet, but this looks wrong as you only test
> version number 1.2.2.24. That would break my mako as it has 1.3.1.0:

I am using 1.2.2.24 version and driver is trying to use
wcn36xx_hal_config_sta_params_v1 instead of just
wcn36xx_hal_config_sta_params. The idea behind this patch is to use
wcn36xx_hal_config_sta_params_v1 for each FW except 1.2.2.24.

> wcn36xx: firmware WLAN version 'WCN v2.0 IRIS v2.0 with 48MHz XO' and CRM version 'AAAAAANAAW122023'
> wcn36xx: firmware API 1.3.1.0, 12 stations, 2 bssids
>
> Can you send the firmware version interface from the device you noticed
> this, please? Does it require struct wcn36xx_hal_config_sta_params_v1?

1.2.2.24 version requires wcn36xx_hal_config_sta_params not
wcn36xx_hal_config_sta_params_v1.

> I think we need to start maintaining a table of different firmware
> versions and what interface they require.

Completely agree. I was thinking to have code something like this:

If version ==  1.2.2.24 then use wcn36xx_hal_config_sta_params
else if version == 1.3.1.0 then use wcn36xx_hal_config_sta_params_v1
else if version == *.*.*.* then use wcn36xx_hal_config_sta_params_v2
...

I guess when we are closer to release we can support only latest FW.
How does that sound?


--
Best regards,
Eugene