[PATCH] Check firmware version more precisely

[Kalle Valo]

Eugene Krasnikov <k.eugene.e at gmail.com> writes:

> Apparently two different minor versions can have different API and
> are not compatible with each other. Let's use more precise version
> check so far to track which firmware has which API.
>
> Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
> ---
>  smd.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/smd.c b/smd.c
> index af38dcc..b5fd0d5 100644
> --- a/smd.c
> +++ b/smd.c
> @@ -463,7 +463,11 @@ int wcn36xx_smd_config_sta(struct wcn36xx *wcn, u8 *bssid, u16 ass_id, u8 *sta_m
>  		sizeof(wcn->supported_rates));
>  	msg_body.sta_params.sta_index = 1;
>  
> -	if (wcn->fw_minor <= 3)
> +	if (!(wcn->fw_major == 1 &&
> +		wcn->fw_minor == 2 &&
> +		wcn->fw_version == 2 &&
> +		wcn->fw_revision == 24))

I haven't tested your patch yet, but this looks wrong as you only test
version number 1.2.2.24. That would break my mako as it has 1.3.1.0:

wcn36xx: firmware WLAN version 'WCN v2.0 IRIS v2.0 with 48MHz XO' and CRM version 'AAAAAANAAW122023'
wcn36xx: firmware API 1.3.1.0, 12 stations, 2 bssids

Can you send the firmware version interface from the device you noticed
this, please? Does it require struct wcn36xx_hal_config_sta_params_v1?

I think we need to start maintaining a table of different firmware
versions and what interface they require.

-- 
Kalle Valo