[PATCH] Check firmware version more precisely

Kalle Valo kvalo at qca.qualcomm.com
Fri May 24 03:19:28 EDT 2013


Eugene Krasnikov <k.eugene.e at gmail.com> writes:

>> I haven't tested your patch yet, but this looks wrong as you only test
>> version number 1.2.2.24. That would break my mako as it has 1.3.1.0:
>
> I am using 1.2.2.24 version

Can you please send your full firmware version information from wcn36xx?
If you can't do it in public, please send it to me privately.

Actually I would like to ask anyone who is using wcn36xx to send the
list (or me privately) information about the firmware version they are
using and what problems there are, if any. That way I could try to
collect what firmware versions and interfaces we need to support (or
prioritise). I could then document this properly.

> and driver is trying to use wcn36xx_hal_config_sta_params_v1 instead
> of just wcn36xx_hal_config_sta_params. The idea behind this patch is
> to use wcn36xx_hal_config_sta_params_v1 for each FW except 1.2.2.24.

Doh, I misunderstood your code. Sorry about that.

>> wcn36xx: firmware WLAN version 'WCN v2.0 IRIS v2.0 with 48MHz XO' and CRM version 'AAAAAANAAW122023'
>> wcn36xx: firmware API 1.3.1.0, 12 stations, 2 bssids
>>
>> Can you send the firmware version interface from the device you noticed
>> this, please? Does it require struct wcn36xx_hal_config_sta_params_v1?
>
> 1.2.2.24 version requires wcn36xx_hal_config_sta_params not
> wcn36xx_hal_config_sta_params_v1.
>
>> I think we need to start maintaining a table of different firmware
>> versions and what interface they require.
>
> Completely agree. I was thinking to have code something like this:
>
> If version ==  1.2.2.24 then use wcn36xx_hal_config_sta_params
> else if version == 1.3.1.0 then use wcn36xx_hal_config_sta_params_v1
> else if version == *.*.*.* then use wcn36xx_hal_config_sta_params_v2
> ...
>
> I guess when we are closer to release we can support only latest FW.
> How does that sound?

Actually I like your original patch more, now that I understood it
correctly :)

But that would be only a temporary solution, I suspect the final
solution will be more complex...

-- 
Kalle Valo



More information about the wcn36xx mailing list