[PATCH V2] Add IEEE80211_TX_CTL_REQ_TX_STATUS support

Eugene Krasnikov k.eugene.e at gmail.com
Fri Jun 7 03:18:33 EDT 2013


Nice work Pontus. I'll check how good AP mode is working with this patch!

Although have some comments;)

> +               /* Only one at a time is supported by fw. Stop the TX queues
> +                * until the ack status gets back.
> +                */
> +               ieee80211_stop_queues(wcn->hw);

Have a concern about this in case FW will never notify driver about
tx_complete and we stuck with stopped queues. Should we have a
watchdog here? I do not suggest to change this patch but to have one
more on top. What do you think about this?


> +       struct tx_compl_ind_msg *rsp = (struct tx_compl_ind_msg *)buf;

Must be  wcn36xx_hal_tx_compl_ind.

--
Best regards,
Eugene



More information about the wcn36xx mailing list