[PATCH V2] Add IEEE80211_TX_CTL_REQ_TX_STATUS support

Kalle Valo kvalo at qca.qualcomm.com
Wed Jun 5 10:14:13 EDT 2013


Pontus Fuchs <pontus.fuchs at gmail.com> writes:

> As there seems to be no packet id in the status indication message
> from the FW, I stop the queues in order to have only one frame with
> IEEE80211_TX_CTL_REQ_TX_STATUS submitted to the FW.
>
> Signed-off-by: Pontus Fuchs <pontus.fuchs at gmail.com>

Looks good, thanks!

> @@ -149,9 +150,14 @@ struct wcn36xx {
>  	struct wcn36xx_dxe_ch	dxe_rx_l_ch;	/* RX low */
>  	struct wcn36xx_dxe_ch	dxe_rx_h_ch;	/* RX high */
>  
> +	/* For synchronization of DXE resources from BH, IRQ and WQ contexts */
> +	spinlock_t	dxe_lock;
> +
>  	/* Memory pools */
>  	struct wcn36xx_dxe_mem_pool mgmt_mem_pool;
>  	struct wcn36xx_dxe_mem_pool data_mem_pool;
> +
> +	struct sk_buff		*tx_ack_skb;
>  };

Here I was thinking of being more explicit, something like this:

/* protected by dxe_lock */
struct sk_buff		*tx_ack_skb;

But this isn't important, it's always easy to improve the documentation
later.

-- 
Kalle Valo



More information about the wcn36xx mailing list