[PATCH V2] Add IEEE80211_TX_CTL_REQ_TX_STATUS support

Pontus Fuchs pontus.fuchs at gmail.com
Fri Jun 7 03:34:52 EDT 2013


On 2013-06-07 09:18, Eugene Krasnikov wrote:
> Nice work Pontus. I'll check how good AP mode is working with this patch!
>
> Although have some comments;)
>
>> +               /* Only one at a time is supported by fw. Stop the TX queues
>> +                * until the ack status gets back.
>> +                */
>> +               ieee80211_stop_queues(wcn->hw);
>
> Have a concern about this in case FW will never notify driver about
> tx_complete and we stuck with stopped queues. Should we have a
> watchdog here? I do not suggest to change this patch but to have one
> more on top. What do you think about this?

Yes. I thought about that. It's needed in general for TX. I left if 
since we lack a way to recover from such a situation. Shall I add a TODO 
comment?

>> +       struct tx_compl_ind_msg *rsp = (struct tx_compl_ind_msg *)buf;
>
> Must be  wcn36xx_hal_tx_compl_ind.
>

Want me to rename in this patch or shall I do it in a cleanup on top? I 
have a cleanup series queued already with some other stuff :)

//Pontus




More information about the wcn36xx mailing list