Purpose of openwrt-devel?

por at oranjevos.nl por at oranjevos.nl
Sun Mar 17 03:44:45 PDT 2024


Op 16 mrt. 2024, om 07:46 heeft Elliott Mitchell <ehem+openwrt at m5p.com> het volgende geschreven:
> 
> On Sat, Mar 16, 2024 at 02:19:27PM +0800, Chuanhong Guo wrote:
>> 
>> On Sat, Mar 16, 2024 at 11:41 AM Elliott Mitchell <ehem+openwrt at m5p.com> wrote:
>>> 
>>> Anyone needing to figure out how the scripts work will need a fair bit
>>> of familiarity with Git.  Being able to get good results really does need
>>> some deep familiarity with Git's structures, at which point
>>> `git fast-import` isn't a big step further.
>> 
>> And more comments on the perl thing:
>> A maintainer needs to be familiar with perl to review or take your
>> patches. I could probably vaguely understand what a perl script
>> is doing by quickly learning the syntax, but I can't decide
>> whether the script is good or not.
>> Nobody is explicitly NACKing your patch or saying it's worse
>> than the bash version just because it's written in perl. Maintainers
>> who don't understand perl simply don't have the knowledge to
>> judge the script, so the patch is left for others. If such a maintainer
>> doesn't show up, your patch won't be taken. It doesn't matter if
>> your script is superior or not.
> 
> That makes forward progress impossible.  If it provides superior results
> then perhaps the thing which only one person understands is acceptable?
> As long as they maintain it, provide reasonable explanations and help
> others work on gaining proper understanding, isn't that good enough?
Ever considered to implement the kernel bumps based on 'git fast-import' in sh script in stead of perl ?
As Chuanhong Guo wrote that patches written in perl are more or less ignored by committers not proficient in perl, ones written in sh will likely have a better chance.

Regards,
Paul




More information about the openwrt-devel mailing list