[PATCH] vc04_services: Fixing coding and logical guidelines

Pushkar Jambhlekar pushkar.iit at gmail.com
Tue Mar 14 22:02:55 PDT 2017

Thanks. I will rewrite patch according to the suggestions.

On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
> On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
>> Description:
> No need for that line.
>>     in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'.
> Why indent?  Also, you need to be specific as to what type of changes
> you made.
>> Also, fixing logical issue, i.e. removing break after goto statement.
> Don't do multiple things in the same patch, break it up into
> one-patch-per-thing, and no, "checkpatch.pl cleanups" is not "one
> thing" :)
> thanks,
> greg k-h

Jambhlekar Pushkar Arun
M.Tech IIT Roorkee

More information about the linux-rpi-kernel mailing list