[PATCH] vc04_services: Fixing coding and logical guidelines

Greg Kroah-Hartman gregkh at linuxfoundation.org
Tue Mar 14 21:52:08 PDT 2017

On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
> Description:

No need for that line.

>     in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'.

Why indent?  Also, you need to be specific as to what type of changes
you made.

> Also, fixing logical issue, i.e. removing break after goto statement.

Don't do multiple things in the same patch, break it up into
one-patch-per-thing, and no, "checkpatch.pl cleanups" is not "one
thing" :)


greg k-h

More information about the linux-rpi-kernel mailing list