[PATCH] RISC-V: cpu_ops_spinwait.c should include head.h

Ben Dooks ben.dooks at sifive.com
Thu Jul 14 00:29:30 PDT 2022


On 14/07/2022 07:33, Conor.Dooley at microchip.com wrote:
> On 13/07/2022 22:53, Ben Dooks wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Running sparse shows cpu_ops_spinwait.c is missing two definitions
>> found in head.h, so include it to stop the following warnings:
>>
>> arch/riscv/kernel/cpu_ops_spinwait.c:15:6: warning: symbol '__cpu_spinwait_stack_pointer' was not declared. Should it be static?
>> arch/riscv/kernel/cpu_ops_spinwait.c:16:6: warning: symbol '__cpu_spinwait_task_pointer' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben.dooks at sifive.com>
> 
> Hey Ben,
> With this applied I still see a:
> arch/riscv/kernel/cpu_ops.c:21:29: warning: symbol 'cpu_ops_spinwait' was not declared. Should it be static?
> 
> Seems to be in the same ballpack, so maybe you could fix that one too?

I've done that as a new patch in case it needs to be moved.
Not sure head.h was the right place nor where it ended up.

-- 
Ben



More information about the linux-riscv mailing list