[PATCH] RISC-V: cpu_ops_spinwait.c should include head.h

Conor.Dooley at microchip.com Conor.Dooley at microchip.com
Wed Jul 13 23:33:20 PDT 2022


On 13/07/2022 22:53, Ben Dooks wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Running sparse shows cpu_ops_spinwait.c is missing two definitions
> found in head.h, so include it to stop the following warnings:
> 
> arch/riscv/kernel/cpu_ops_spinwait.c:15:6: warning: symbol '__cpu_spinwait_stack_pointer' was not declared. Should it be static?
> arch/riscv/kernel/cpu_ops_spinwait.c:16:6: warning: symbol '__cpu_spinwait_task_pointer' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks at sifive.com>

Hey Ben,
With this applied I still see a:
arch/riscv/kernel/cpu_ops.c:21:29: warning: symbol 'cpu_ops_spinwait' was not declared. Should it be static?

Seems to be in the same ballpack, so maybe you could fix that one too?

FWIW:
# CONFIG_RISCV_BOOT_SPINWAIT is not set
Thanks,
Conor.

> ---
>   arch/riscv/kernel/cpu_ops_spinwait.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/riscv/kernel/cpu_ops_spinwait.c b/arch/riscv/kernel/cpu_ops_spinwait.c
> index 346847f6c41c..c662a7cf10a4 100644
> --- a/arch/riscv/kernel/cpu_ops_spinwait.c
> +++ b/arch/riscv/kernel/cpu_ops_spinwait.c
> @@ -11,6 +11,8 @@
>   #include <asm/sbi.h>
>   #include <asm/smp.h>
> 
> +#include "head.h"
> +
>   const struct cpu_operations cpu_ops_spinwait;
>   void *__cpu_spinwait_stack_pointer[NR_CPUS] __section(".data");
>   void *__cpu_spinwait_task_pointer[NR_CPUS] __section(".data");
> --
> 2.35.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv



More information about the linux-riscv mailing list