[PATCH 04/18] reset: rzv2h-usb2phy: Set VBENCTL register for OTG mode

Philipp Zabel p.zabel at pengutronix.de
Mon Oct 6 09:31:39 PDT 2025


On Mi, 2025-10-01 at 23:26 +0200, Tommaso Merciai wrote:
> Add logic to set the VBENCTL register when the USB controller operates in
> OTG mode. This is required to ensure proper USB transceiver behavior when
> the device is configured as OTG.
> 
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr at bp.renesas.com>

I had reservations about this driver before, because of the opaque
register initialization sequence, and I was told that no, this is a
reset driver alright [1].

Can you please try to find a proper abstraction for this, because
drivers/reset is not the correct place for USB OTG mode handling.

[1] https://lore.kernel.org/all/TYCPR01MB12093DB963348A8FD58409E5AC2DE2@TYCPR01MB12093.jpnprd01.prod.outlook.com/


regards
Philipp



More information about the linux-phy mailing list