[PATCH 04/18] reset: rzv2h-usb2phy: Set VBENCTL register for OTG mode

[Biju Das]

Hi Philipp,

Thanks for the feedback.

> -----Original Message-----
> From: Philipp Zabel <p.zabel at pengutronix.de>
> Sent: 06 October 2025 17:32
> Subject: Re: [PATCH 04/18] reset: rzv2h-usb2phy: Set VBENCTL register for OTG mode
> 
> On Mi, 2025-10-01 at 23:26 +0200, Tommaso Merciai wrote:
> > Add logic to set the VBENCTL register when the USB controller operates
> > in OTG mode. This is required to ensure proper USB transceiver
> > behavior when the device is configured as OTG.
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr at bp.renesas.com>
> 
> I had reservations about this driver before, because of the opaque register initialization sequence, and
> I was told that no, this is a reset driver alright [1].

The latest hardware manual document about VBENCTRL register which sets source for VBUS selection.
s
> 
> Can you please try to find a proper abstraction for this, because drivers/reset is not the correct place
> for USB OTG mode handling.

Sorry for the confusion. This driver is not handling USB OTG mode. It just configures VBENCTRL(one time setting)
that selects the source for VBUS_SEL. Actual USB OTG mode handling is done USB PHY driver
which sets host/device mode based on ID detection.

Cheers,
Biju