[PATCH] pcmcia: correct operation ordering in pcmcia_register_client [Was: Re: Fw: PCMCIA bug in 2.6.11rc2]

Dominik Brodowski linux at dominikbrodowski.de
Fri Feb 4 13:17:43 EST 2005


From: Josh Green <jgreen at users.sourceforge.net>

A wrong ordering of operators in pcmica_register_client() causes
initialization problems with multiple PCMCIA cards.

Signed-off-by: Josh Green <jgreen at users.sourceforge.net>
Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.de>

--- linux/drivers/pcmcia/ds.c.orig	2005-02-04 19:12:59.000000000 +0100
+++ linux/drivers/pcmcia/ds.c	2005-02-04 19:13:16.000000000 +0100
@@ -660,7 +660,7 @@
 			p_dev = pcmcia_get_dev(p_dev);
 			if (!p_dev)
 				continue;
-			if ((!p_dev->client.state & CLIENT_UNBOUND) ||
+			if (!(p_dev->client.state & CLIENT_UNBOUND) ||
 			    (!p_dev->dev.driver)) {
 				pcmcia_put_dev(p_dev);
 				continue;



More information about the linux-pcmcia mailing list