[PATCH 05/14] nvmet: get rid of the extra variable

Keith Busch kbusch at kernel.org
Mon Aug 10 19:13:46 EDT 2020


On Mon, Aug 10, 2020 at 11:00:55PM +0000, Chaitanya Kulkarni wrote:
> On 8/10/20 14:58, Logan Gunthorpe wrote:
> > IMO, that's really ugly and not at all an improvement.
> > 
> > Logan
> 
> && operator is perfectly readable when use for short circuit two 
> conditions, more than 2 or newline is what ugly not this one.

The odd looking part is mixing "likely()" and "unlikely()" in the same
conditional.



More information about the Linux-nvme mailing list