[PATCH 05/14] nvmet: get rid of the extra variable

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Mon Aug 10 19:00:55 EDT 2020


On 8/10/20 14:58, Logan Gunthorpe wrote:
> IMO, that's really ugly and not at all an improvement.
> 
> Logan

&& operator is perfectly readable when use for short circuit two 
conditions, more than 2 or newline is what ugly not this one.

There are several places in kernel this pattern is present, if it
was ugly that code have never been accepted by the kernel standards.




More information about the Linux-nvme mailing list