[PATCH] nvme/pci: Log PCI_STATUS when the controller dies

Keith Busch keith.busch at intel.com
Thu Dec 1 10:09:43 PST 2016


On Wed, Nov 30, 2016 at 10:28:03AM -0800, Andy Lutomirski wrote:
> In theory, although not (AFAIK) on x86, config space reads can fail
> outright.  Normally a failure looks like returning 0xffff, so I
> figured I'd make it consistent.  I could alternatively check the
> return value and print a different message if pci_read_config_word
> fails.

I agree it'd be nice to know if we actually got all 1's from hardware,
or the pci config read itself returned an error without setting the
status. x86 should be returning all 1's on a failure, but don't want to
always count on that.



More information about the Linux-nvme mailing list