[PATCH] mtd: ck804xrom: fix missing pci device put in error paths

Miquel Raynal miquel.raynal at bootlin.com
Mon Aug 31 08:00:32 EDT 2020


Hi James,

James Bond <jameslouisebond at gmail.com> wrote on Fri, 28 Aug 2020
21:28:40 -0500:

> Hi Miquèl,
> Thanks for your feedback.
> I have just rechecked this function and find that "pdev" currently is
> already put
> inside ck804xrom_cleanup, so my previous patch is meaningless...
> The current calling order is like:
> 
> window->pdev = pci_dev_get(pdev);
> ...
>     ck804xrom_cleanup(window)
>              ->  
>                   pci_dev_put(window->pdev);
> And sorry for bothering you.

Ok that's fine, thanks anyway!

Miquèl



More information about the linux-mtd mailing list