[PATCH 2/2] nanddump: add --nobad to read bad blocks

Artem Bityutskiy dedekind1 at gmail.com
Mon Sep 13 02:24:30 EDT 2010


On Mon, 2010-09-13 at 08:22 +0200, Wolfram Sang wrote:
> On Mon, Sep 13, 2010 at 06:50:04AM +0100, Jon Povey wrote:
> > Mike Frysinger wrote:
> > > Sometimes dumping bad blocks is useful, like when the data isn't actually
> > > bad but the OOB layout isn't what the kernel is expecting or is otherwise
> > > screwed up.  The --nobad option allows just that.
> > 
> > > +"-N         --nobad              Read without bad block skipping\n"
> > 
> > This doesn't seem like a good name for the option to me. A useful option but
> > an unintuitive name, "nobad" sounds like it is going to omit bad blocks,
> > where actually it is going to include them.
> > 
> > "noskipbad" or "includebad" would seem to be better.
> 
> I agree. Is that still fixable despite being pushed already?

Sure, send a patch please.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list